Update to a more extensible deprecation method. #1043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobbyMcWho
commented
Sep 30, 2019
| @@ -59,4 +59,4 @@ def certificate_store | |||
| end | |||
| end | |||
|
|
|||
| EventMachine::HttpStubConnection.send(:include, EmHttpSslPatch) | |||
| EventMachine::HttpStubConnection.include(EmHttpSslPatch) | |||
There was a problem hiding this comment.
Rubocop made me do it 🚓 🤖
BobbyMcWho
commented
Sep 30, 2019
| end | ||
|
|
||
| it 'does not raise an error for inherited error-namespaced classes but prints an error message' do | ||
| error_message, = with_warn_squelching { class E < Faraday::Error::ClientError; end } |
There was a problem hiding this comment.
this looks like a typo, but it's not. Rubocop likes
a, = [:foo, :bar] better than
a, _ = [:foo, :bar] 🤷♂
2 tasks
The previous implementation would not warn about deprecation upon being inherited, and warned in a stdout. This implementation warns in stderr similar to Gem::Deprecate, but gives a semver instead of a date like the default Gem::Deprecate does.
BobbyMcWho
force-pushed
the
create-extensible-faraday-deprecate
branch
from
fe63747
to
cd7888f
Compare
|
FYI: This closed because I killed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation would not warn about deprecation upon being inherited, and warned in stdout. Upon initialization or Inheritance, this implementation warns in stderr similar to Gem::Deprecate, but gives a semver instead of a date like the default Gem::Deprecate does.