Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship 1.0 #1101

Merged
merged 8 commits into from
Jan 1, 2020
Merged

Ship 1.0 #1101

merged 8 commits into from
Jan 1, 2020

Conversation

technoweenie
Copy link
Member

@technoweenie technoweenie commented Dec 30, 2019

  • Review/merge error class changes improve error initializer consistency #1095
  • push Faraday::Deprecate upstream for eventual 2.0 deprecations?
    • no need now. we can grab it any time.
  • double check readme/gemfile/etc for consistency in faraday website, supported ruby versions, gems, etc. also update minimum ruby version to 2.4.0
  • bump supported addressable version from <2.4.0 to <2.7.0?
    • addressable version is unspecified already
  • bump supported ruby version to 2.3.x or 2.4.x?
  • drop CONNECT method support?
  • Changelog
  • Verify against technoweenie/faraday-live

Items ending in ? are suggestions...

@technoweenie technoweenie mentioned this pull request Dec 30, 2019
5 tasks
@technoweenie
Copy link
Member Author

I ran the faraday-live test suite against this branch, and the current version of Typhoeus in Git (until v1.4.0 is released). I ran into this issue with the CONNECT calls:

  1) typhoeus with HTTPS server (typhoeus) #CONNECT request behaves like an idempotent request returns Content-Type response header
     Failure/Error: @response = conn.public_send(http_method, 'idempotent_request')

     Faraday::ConnectionFailed:
       Stream error in the HTTP/2 framing layer
     Shared Example Group: "any request" called from ./spec/support/examples/request_idempotent.rb:11
     Shared Example Group: "an idempotent request" called from ./spec/support/examples/connection.rb:24
     Shared Example Group: "a connection making requests" called from ./spec/secure_spec.rb:5

I propose that we cut CONNECT method support before 1.0. It's never actually showed up in a release version of Faraday, so it won't be a breaking change. While TRACE is obscure, it's easy enough to support. However, CONNECT seems to be used for proxy servers, which doesn't work well with Faraday's request/response nature.

spec/faraday/response/logger_spec.rb:73: warning: Using the last argument as
keyword parameters is deprecated; maybe ** should be added to the call

lib/faraday/logging/formatter.rb:13: warning: The called method 'initialize'
is defined here
@technoweenie
Copy link
Member Author

I think this is ready to go now. I've updated the changelog, including the 0.17.x updates that weren't ever written to the master branch's changelog.

I also added author attributions for items in Faraday 0.14.0, but that was because I was accidentally adding the new changelog items in the wrong place :)

Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship ahoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants