-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship 1.0 #1101
Ship 1.0 #1101
Conversation
I ran the faraday-live test suite against this branch, and the current version of Typhoeus in Git (until v1.4.0 is released). I ran into this issue with the
I propose that we cut |
spec/faraday/response/logger_spec.rb:73: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call lib/faraday/logging/formatter.rb:13: warning: The called method 'initialize' is defined here
I think this is ready to go now. I've updated the changelog, including the 0.17.x updates that weren't ever written to the master branch's changelog. I also added author attributions for items in Faraday 0.14.0, but that was because I was accidentally adding the new changelog items in the wrong place :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship ahoy!
Items ending in
?
are suggestions...