Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CI to remove duplicated line #1230

Merged
merged 1 commit into from Jan 2, 2021

Conversation

@tricknotes
Copy link
Contributor

@tricknotes tricknotes commented Jan 2, 2021

Description

"libcurl4-openssl-dev" is already installed in previous step.
https://github.com/lostisland/faraday/blob/v1.3.0/.github/workflows/ci.yml#L54-L56

Todos

List any remaining work that needs to be done, i.e:

  • Pass CI

Additional Notes

This line was added in #1100, but it seems unintentional.

"libcurl4-openssl-dev" is already installed in previous step.
@tricknotes tricknotes marked this pull request as ready for review Jan 2, 2021
Copy link
Member

@olleolleolle olleolleolle left a comment

Good eye! Thanks, @tricknotes!

@olleolleolle olleolleolle merged commit 086bb62 into lostisland:master Jan 2, 2021
7 checks passed
7 checks passed
@github-actions
linting
Details
@github-actions
build 2.4
Details
@github-actions
build 2.5
Details
@github-actions
build 2.6
Details
@github-actions
build 2.7
Details
@github-actions
build 3.0
Details
codeclimate All good!
Details
@tricknotes tricknotes deleted the tricknotes:refactor-ci branch Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants