-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.x] Deprecate Authorization helpers in Faraday::Connection #1306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super deprecated!
Nice with the docs changes. Idea: promote the Authorization to first place, the others being not as recommended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay!
I like this suggestion, and also the introduction could use some rewording, it's much better now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready to go, I think! 🥳
Hi, how about marking the deprecated methods by the YARD |
Oh, sorry. I see the methods were deleted via #1308. 😅 |
We'll keep the YARD tag in mind for the next time we make a release with a deprecation! Thanks! |
I'm getting |
@thelucid it most definitely is, it appears something is calling the now deprecated If you point me to the right place in the code where this happen, I might be able to provide further help |
Description
After reviewing the authorisation part of middleware, I realised we currently expose helpers in
Faraday::Connection
to setup theAuthorization
header. The implementation is quite old (I couldn't find any reference to theToken
type, it seems it has been replaced byBearer
), with intra-dependencies that make the code hard to read and maintain.I believe in v2.0 we should remove the helpers and rework the middleware, but in the meantime this PR will add a deprecation warning to the
1.x
branch: