Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry middleware should handle string exception class name consistently #1334

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

jrochkind
Copy link
Contributor

Closes #1330

Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jrochkind, code changes look good!
We just need to make CI passing and then LGTM 💯 🎉

@jrochkind jrochkind force-pushed the retry_exceptions_option_string branch from cfb2b37 to 270f1bf Compare October 12, 2021 14:11
@jrochkind
Copy link
Contributor Author

Thanks! I believe I will have made rubocop happier now.

@iMacTia iMacTia merged commit 1d567df into lostisland:main Oct 12, 2021
jrochkind added a commit to jrochkind/faraday that referenced this pull request Dec 20, 2021
jrochkind added a commit to jrochkind/faraday that referenced this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

retry middleware, exceptions option as String does not match on exception sub-classes
2 participants