Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve request info in exceptions raised by RaiseError Middleware #1335

Merged
merged 3 commits into from
Oct 16, 2021
Merged

Improve request info in exceptions raised by RaiseError Middleware #1335

merged 3 commits into from
Oct 16, 2021

Conversation

willianzocolau
Copy link
Contributor

Description

A few sentences describing the overall goals of the pull request's commits.
Link to related issues if any. (As fixes #XXX )

Fixes #1249

Add URI object with the url requested and fix query string params. In test adapter, the params already was treated which means the specs was biased. With default adapter, the params problem occurred as described in Issue #1249.

Todos

List any remaining work that needs to be done, i.e:

  • Tests
  • Documentation

Additional Notes

Optional section

Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @willianzocolau and thanks for fixing this!

I just want to point out that this PR will be merged on the main branch, and that currently contains the code that will go in the next major release (v2.0).

If you'd like to have this change released for Faraday v1 as well, then you'll need open another PR against the 1.x branch. This is absolutely not a requirement though, so feel free to ignore if you're planning to use v2.0 anyway.

@iMacTia iMacTia merged commit ceeaa74 into lostisland:main Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faraday::Error does not provide original request URL or params
2 participants