Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TooManyRequests error #1530

Merged
merged 1 commit into from
Oct 20, 2023
Merged

TooManyRequests error #1530

merged 1 commit into from
Oct 20, 2023

Conversation

dpep
Copy link
Contributor

@dpep dpep commented Oct 20, 2023

Description

Faraday enumerates many common HTTP errors....could we please add 429 / TooManyRequests to the list?

Todos

List any remaining work that needs to be done, i.e:

  • Tests

@dpep dpep changed the title 429 error TooManyRequests error Oct 20, 2023
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Thanks, @dpep!

@olleolleolle olleolleolle merged commit 63ba2aa into lostisland:main Oct 20, 2023
8 checks passed
@dpep dpep deleted the 429-error branch October 20, 2023 23:50
tijmenb added a commit to tijmenb/faraday that referenced this pull request Jun 4, 2024
`TooManyRequestsError` for HTTP 429 was added in lostisland#1530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants