NetHttp uses with_net_http_connection (#446) #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@technoweenie would you prefer this with or without the version bump? |
|
Typically I do version bumps separately. The changelog edit is good. Since there's not much Faraday action going on, I can merge this and push a new version out. |
technoweenie
added a commit
that referenced
this pull request
Jan 7, 2015
NetHttp uses with_net_http_connection (#446)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #446 this switches Net:Http to use 'with_net_http_connection' internally, so that it can be overridden to allow for connection pooling.
Let me know if you'd prefer me to remove the version bump.