Add SOCKS support with socksify #485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no experience with SOCKS, but to add a feature to an adapter in Faraday, the attempt must be made to add the same feature to all other adapters as well. Think you can look into it? Also, we have automated tests for all HTTP and proxy server functionality. In order to add tests for this, you would have to spin up a SOCKS server in test mode. If you think you can do that, please explore this direction. I don't have the bandwidth to work on this myself. Thanks! |
|
closing as stale |
This was referenced Jul 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a SOCKS (SOCKS5) connection with Faraday, using the socksify gem.