don't stomp on request body #517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanej
commented
Sep 1, 2015
lanej
commented
- store request_body in env
- allow response to contain all the information of the request
* store request_body in env * allow response to contain all the information of the request
|
Waiting for anything before merging this? Looks like a great addition! |
|
@iMacTia still waiting on the verdict |
|
8 months later... 😕 |
14 tasks
|
2 years later ... :( |
iMacTia
added a commit
that referenced
this pull request
Feb 14, 2019
* They're now final endpoints. They don't call `@app.call` anymore. * Env refactoring * Refactors `Env` by moving all response-related fields into the response. The response body doesn't override the request body anymore! * Ensures backwards compatibility by introducing getter methods in `Env`. * Middlewares refactoring (mostly backwards compatible): * All middlewares inherit from the same `Faraday::Middleware` class. * Adds new `on_request` helper so basic middlewares (request and response) don't need to override `call` anymore. * Refactor existing middlewares to reflect this change. * Updates UPGRADING.md with all breaking changes. Fixes #47 once and for all! Fixes #517
|
This is now being addressed as part of #845 and will be available in v1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.