Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document missing :retry_statuses argument #957

Merged
merged 2 commits into from Mar 30, 2019
Merged

document missing :retry_statuses argument #957

merged 2 commits into from Mar 30, 2019

Conversation

technoweenie
Copy link
Member

@technoweenie technoweenie commented Mar 29, 2019 •
edited

This documents a missing argument for the Retry middleware. Open to suggestions on the wording and yard syntax.

/cc #955

olleolleolle
olleolleolle approved these changes Mar 30, 2019
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome (found a typo, marked it) and happy to have this!

lib/faraday/request/retry.rb Outdated Show resolved Hide resolved
@technoweenie technoweenie merged commit ef8d9eb into master Mar 30, 2019
@technoweenie technoweenie deleted the docs-retry-arg branch March 30, 2019 14:52
@iMacTia iMacTia mentioned this pull request Feb 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@technoweenie @olleolleolle