Clear Authorization header when redirecting cross-site #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to allow for the Authorization header to be cleared on redirects
The rubysl-json gem has been yanked so use the json gem instead.
…aday_middleware into clear-auth-header
iMacTia
requested changes
Jan 11, 2019
There was a problem hiding this comment.
Hi @kyoshidajp, sorry for the late review but I completely missed your PR 🙈
Left some comments, happy to review again once they've been addressed 👍
Co-Authored-By: kyoshidajp <claddvd@gmail.com>
Co-Authored-By: kyoshidajp <claddvd@gmail.com>
iMacTia
approved these changes
Feb 4, 2019
|
@iMacTia Thank you for reviewing! |
|
@kyoshidajp Thanks to you for contributing 🙌 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue that Authorization header remains during redirect to cross-site.
This PR is related to #81. I added the commit that clear header only redirect to cross-site and that spec.