Buxfix when time_field is not string #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a time_field? determined value is not string dont parse it.
| @@ -99,7 +99,7 @@ def decode_hash(hash) | |||
| end | |||
|
|
|||
| def decode_hash_value(key, value) | |||
| if time_field?(key, value) | |||
| if value.is_a?(String) && time_field?(key, value) | |||
There was a problem hiding this comment.
We could probably move this guard inside of the time_field? method for clarity. It would be great if we we could find a way to call Time.at on Unix epoch values.
There was a problem hiding this comment.
consider all float and integer value as Unix timestamp?
|
mistakenly closed |
|
⚡ |
pengwynn
added a commit
that referenced
this pull request
Mar 24, 2014
Buxfix when time_field is not string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't parse non string value as time.