Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1/1 occludes preview text #291

Closed
nh2 opened this issue Mar 21, 2020 · 3 comments
Closed

1/1 occludes preview text #291

nh2 opened this issue Mar 21, 2020 · 3 comments
Milestone

Comments

@nh2
Copy link

nh2 commented Mar 21, 2020

I'd like to copy-pase text out of the preview window, but the 1/1 overlay text "occludes" (overrides) some of the contents:

image

How can I disable the 1/1?

In general, I've had trouble figuring out what that even is (is it some kind of page counter for the preview window?).

It would be great if the README could document what it is.

@lotabout
Copy link
Owner

@nh2 Problem understood.

In general, I've had trouble figuring out what that even is (is it some kind of page counter for the preview window?).

It's actually line_num/total_line_num of the text to preview. Was designed to let user know the current offset.

As for how to fix, I don't like to have an option for every small tweak. Currently a "reasonable default" that I could come up with:

  • Do not show the pager if the content could fit the window.
  • Do not show the pager if the offset is 0.
  • Show the pager otherwise.

@lotabout lotabout added this to the v0.8.3 milestone Apr 1, 2020
lotabout added a commit that referenced this issue Apr 8, 2020
fix #291: hide scroll info when content fit
@lotabout
Copy link
Owner

lotabout commented Apr 8, 2020

The final solution is a bit different to what's described above: the offset would still be shown if the content could not fit into the window event when the offset is 0.

@nh2
Copy link
Author

nh2 commented Apr 8, 2020

@lotabout Would you mind posting a screenshot of your solution?

My problem is not that a pager is shown when not needed, but that

  • I cannot read the characters below the 1/1 (which is important to figure out whether that's the line I want to select or not)
  • I cannot copy-paste the contents of the preview window out.

These might be fixed trivially by moving the pager one row up, to be part of the "separator" line.

makovich pushed a commit to makovich/skim that referenced this issue May 28, 2020
- Do not show the pager if the content could fit the window.
- Show the pager otherwise.
lotabout added a commit that referenced this issue Jul 1, 2020
Revert "fix #291: hide scroll info when content fit"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants