Add shutdown timeout #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With both xterm (v366) and konsole (20.12.2) using rustc 1.52.1 the shutdown sometimes hangs indefinitely, so a timeout is added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With both xterm (v366) and konsole (20.12.2) using rustc 1.52.1 the
shutdown sometimes hangs indefinitely, so a timeout is added.
This happens both with and without
clear_on_exit, and so far I could only reproduce it with release binaries, not with debug ones. Note that this just fixes the symptom, I do not know if the cause is actually misbehavior of the terminal or something else.