feat: registration compat for 0.68/0.69 #1057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is needed because I don't think it's a good idea to turn on new architecture on 68/69. New architecture support is still experimental and most production apps are not using it. |
|
Fine. We could leave the PR open as a reminder |
satya164
pushed a commit
to callstack/react-native-builder-bob
that referenced
this pull request
Aug 25, 2023
### Summary `develop mode` condition is inspired by [`react-native-reanimated` build.gradle](https://github.com/software-mansion/react-native-reanimated/blob/main/android/build.gradle) It uses the lock version of `react-native` dependency of library when compiling `example` The lock version fails the build when there are different versions of `react-native` in each variant of examples For example, https://github.com/Sunbreak/lottie-react-native/tree/compat-example - [apps/fabric](https://github.com/Sunbreak/lottie-react-native/tree/compat-example/apps/fabric) use `react-native@0.71.11` - [apps/fabric-compat](https://github.com/Sunbreak/lottie-react-native/tree/compat-example/apps/fabric) use `react-native@0.69.4` ### Test plan lottie-react-native/lottie-react-native#1057 is PR of lottie-react-native for compat with `react-native@0.69.4`
matinzd
force-pushed
the
fabric-compat
branch
from
09ea5c2
to
260453f
Compare
|
It's not needed since we are not going to support versions lower than 70 anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Support for Fabric on 0.68/0.69 requires manual registration inside custom
RNScreensComponentsRegistry, according to Introducing Fabric to react-native-screens, especially Android base changesSolution
Backport
lottie-react-nativeto 0.68/0.69 as callstack/react-native-builder-bob#360Test Plan
Tested on
fabric-compatexample: https://github.com/Sunbreak/lottie-react-native/tree/compat-example