fix(ios): save resizeMode and reapply it when replacing a view
#1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRogue76
reviewed
Dec 22, 2023
TheRogue76
reviewed
Dec 22, 2023
|
Hi @hardworker. Thank you for the contribution. I left two comments, once you had time to address those, please test on new Arch and old arch, and we can get this merged 🙏 |
|
Hi @hardworker. We are planning on doing a release after this is merged. Please let me know if you can wrap up the fixes in the upcoming week, otherwise i can just do the minor adjustments in this PR and do the tests and we can have this merged and as part of the release 🙏. |
|
Any updates on this? |
|
Hey, @TheRogue76! Sure, I'll do the fixes later today and ping you :) |
hardworker
force-pushed
the
fix/resizeMode-on-ios
branch
from
c8d0aac
to
3a283dd
Compare
hardworker
force-pushed
the
fix/resizeMode-on-ios
branch
from
3a283dd
to
9aaf79a
Compare
|
@TheRogue76 Hello again, I made the necessary changes, added a small fix to address a SwiftLint warning and tested on both Fabric and Paper, works just fine! |
TheRogue76
approved these changes
Dec 29, 2023
github-merge-queue bot
pushed a commit
to valora-inc/wallet
that referenced
this pull request
Apr 22, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [lottie-react-native](https://togithub.com/airbnb/lottie-react-native#readme) ([source](https://togithub.com/react-native-community/lottie-react-native)) | [`^5.1.6` -> `^6.7.2`](https://renovatebot.com/diffs/npm/lottie-react-native/5.1.6/6.7.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-community/lottie-react-native (lottie-react-native)</summary> ### [`v6.7.2`](https://togithub.com/lottie-react-native/lottie-react-native/releases/tag/v6.7.2) [Compare Source](https://togithub.com/react-native-community/lottie-react-native/compare/v6.7.1...v6.7.2) ##### What's Changed - fix: incorrect type for macos by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1218 **Full Changelog**: lottie-react-native/lottie-react-native@v6.7.1...v6.7.2 ### [`v6.7.1`](https://togithub.com/lottie-react-native/lottie-react-native/releases/tag/v6.7.1) [Compare Source](https://togithub.com/react-native-community/lottie-react-native/compare/v6.7.0...v6.7.1) This Release addresses the issue with Lottie-iOS 4.4.2 being automatically picked and requiring iOS 13 as a minimum target. ##### What's Changed - Typo fixed by [@​minlaxz](https://togithub.com/minlaxz) in [lottie-react-native/lottie-react-native#1197 - Improve web consistency with native by [@​arasrezaei](https://togithub.com/arasrezaei) in [lottie-react-native/lottie-react-native#1196 - chore: remove mention of [@​lottiefiles/react-lottie-player](https://togithub.com/lottiefiles/react-lottie-player) in README.md by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1205 - refactor(web): replace inline require with import by [@​adamhari](https://togithub.com/adamhari) in [lottie-react-native/lottie-react-native#1206 - fix: pin lottie ios version in pod spec by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1217 - chore: bump Lottie Android to 6.4.0 by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1209 ##### New Contributors - [@​minlaxz](https://togithub.com/minlaxz) made their first contribution in [lottie-react-native/lottie-react-native#1197 - [@​arasrezaei](https://togithub.com/arasrezaei) made their first contribution in [lottie-react-native/lottie-react-native#1196 **Full Changelog**: lottie-react-native/lottie-react-native@v6.7.0...v6.7.1 ### [`v6.7.0`](https://togithub.com/lottie-react-native/lottie-react-native/releases/tag/v6.7.0) [Compare Source](https://togithub.com/react-native-community/lottie-react-native/compare/v6.6.0...v6.7.0) #### Bridgeless support Bridgeless is now officially supported as of React Native 0.73.4. #### What's Changed - fix: update RN to fix the pipeline by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1174 - chore: Update MIGRATION-5-TO-6.md by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1172 - feat: add experimental bridgeless support by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1160 - \[Windows]Add windows to lottie published files by [@​jfkm69](https://togithub.com/jfkm69) in [lottie-react-native/lottie-react-native#1176 - chore: bump lottie ios by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1191 - chore: bump Fabric to latest RN by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1192 - feat: re-add paper event names to the spec by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1193 #### New Contributors - [@​jfkm69](https://togithub.com/jfkm69) made their first contribution in [lottie-react-native/lottie-react-native#1176 **Full Changelog**: lottie-react-native/lottie-react-native@v6.6.0...v6.7.0 ### [`v6.6.0`](https://togithub.com/lottie-react-native/lottie-react-native/releases/tag/v6.6.0) [Compare Source](https://togithub.com/react-native-community/lottie-react-native/compare/v6.5.1...v6.6.0) #### Supporting upcoming requirements from Apple During WWDC2023, Apple introduced a new feature: [Privacy manifest for SDKs](https://developer.apple.com/videos/play/wwdc2023/10060/). While this is optional for most libraries, Apple also mentioned that [certain third party SDKs](https://developer.apple.com/support/third-party-SDK-requirements/) are required to support the manifest. This includes Lottie. This release updates Lottie-iOS to 4.4.0, which now includes the privacy manifest, as well as adding support for it in Lottie React Native as well. These requirements will go into effect come Spring 2024. For more information, click [here](https://togithub.com/lottie-react-native/lottie-react-native/issues/1169). #### What's Changed - chore: add linting to paper's build step on Android by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1155 - Update README.md: LottieView must set the `width` and `height` styles to display properly by [@​coder-xiaomo](https://togithub.com/coder-xiaomo) in [lottie-react-native/lottie-react-native#1157 - chore: update documentation to include a new migration doc from V5 to V6 by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1156 - fix: update api doc by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1164 - feat: add privacy manifest for iOS by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1163 - chore: bump lottie ios version by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1165 - chore: mention the new privacy manifests in the Read Me by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1166 #### New Contributors - [@​coder-xiaomo](https://togithub.com/coder-xiaomo) made their first contribution in [lottie-react-native/lottie-react-native#1157 **Full Changelog**: lottie-react-native/lottie-react-native@v6.5.1...v6.6.0 ### [`v6.5.1`](https://togithub.com/lottie-react-native/lottie-react-native/releases/tag/v6.5.1) [Compare Source](https://togithub.com/react-native-community/lottie-react-native/compare/v6.5.0...v6.5.1) #### What's Changed - chore(ci): fix ios-fabric-build.yml by [@​matinzd](https://togithub.com/matinzd) in [lottie-react-native/lottie-react-native#1149 - fix: remove incorrect typeface default by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1151 **Full Changelog**: lottie-react-native/lottie-react-native@v6.5.0...v6.5.1 ### [`v6.5.0`](https://togithub.com/lottie-react-native/lottie-react-native/releases/tag/v6.5.0) [Compare Source](https://togithub.com/react-native-community/lottie-react-native/compare/v6.4.1...v6.5.0) #### What's Changed - fix: animation frames being incorrect on new arch for the first frame by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1140 - chore(iOS): Use `install_modules_dependencies` in Podspec by [@​cipolleschi](https://togithub.com/cipolleschi) in [lottie-react-native/lottie-react-native#1139 - chore: upgrade example fabric to 73 by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1143 - fix(workaround): enable `install_modules_dependencies` just for RN 73 and above by [@​matinzd](https://togithub.com/matinzd) in [lottie-react-native/lottie-react-native#1146 - feat(android): support local file path by [@​jhen0409](https://togithub.com/jhen0409) in [lottie-react-native/lottie-react-native#1134 - Update bug_report.md by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1147 - feat: add CI for new arch by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1145 - fix(ios): save `resizeMode` and reapply it when replacing a view by [@​hardworker](https://togithub.com/hardworker) in [lottie-react-native/lottie-react-native#1144 #### New Contributors - [@​cipolleschi](https://togithub.com/cipolleschi) made their first contribution in [lottie-react-native/lottie-react-native#1139 - [@​hardworker](https://togithub.com/hardworker) made their first contribution in [lottie-react-native/lottie-react-native#1144 #### Developer notes This build focuses more on stability on the new architecture and adding support for RN 0.73. **Merry Christmas and Happy new year! 🎅 🎄** **Full Changelog**: lottie-react-native/lottie-react-native@v6.4.1...v6.5.0 ### [`v6.4.1`](https://togithub.com/lottie-react-native/lottie-react-native/releases/tag/v6.4.1) [Compare Source](https://togithub.com/react-native-community/lottie-react-native/compare/v6.4.0...v6.4.1) #### What's Changed - fix(web): don't require [@​dotlottie/react-player](https://togithub.com/dotlottie/react-player) to be installed for JSON animations by [@​adamhari](https://togithub.com/adamhari) in [lottie-react-native/lottie-react-native#1127 - fix(ios): missing configuration if textFilters used by [@​jhen0409](https://togithub.com/jhen0409) in [lottie-react-native/lottie-react-native#1129 - feat(android): support font assets by [@​jhen0409](https://togithub.com/jhen0409) in [lottie-react-native/lottie-react-native#1128 - feat: Add callback for when animation has loaded by [@​thevoiceless](https://togithub.com/thevoiceless) in [lottie-react-native/lottie-react-native#1120 - chore: add warning for agp namespace by [@​matinzd](https://togithub.com/matinzd) in [b35010](https://togithub.com/lottie-react-native/lottie-react-native/commit/b3501015276782d21947dcb42cfa967cbb503813) #### New Contributors - [@​adamhari](https://togithub.com/adamhari) made their first contribution in [lottie-react-native/lottie-react-native#1127 **Full Changelog**: lottie-react-native/lottie-react-native@v6.4.0...v6.4.1 ### [`v6.4.0`](https://togithub.com/lottie-react-native/lottie-react-native/releases/tag/v6.4.0) [Compare Source](https://togithub.com/react-native-community/lottie-react-native/compare/v6.3.1...v6.4.0) #### What's Changed - feat: add web support by [@​kosmydel](https://togithub.com/kosmydel) in [lottie-react-native/lottie-react-native#1107 #### New Contributors - [@​kosmydel](https://togithub.com/kosmydel) made their first contribution in [lottie-react-native/lottie-react-native#1107 **Full Changelog**: lottie-react-native/lottie-react-native@v6.3.1...v6.4.0 ### [`v6.3.1`](https://togithub.com/lottie-react-native/lottie-react-native/releases/tag/v6.3.1) [Compare Source](https://togithub.com/react-native-community/lottie-react-native/compare/v6.3.0...v6.3.1) #### What's Changed - fix: android build issue by [@​matinzd](https://togithub.com/matinzd) in [lottie-react-native/lottie-react-native#1106 **Full Changelog**: lottie-react-native/lottie-react-native@v6.3.0...v6.3.1 ### [`v6.3.0`](https://togithub.com/lottie-react-native/lottie-react-native/releases/tag/v6.3.0) [Compare Source](https://togithub.com/react-native-community/lottie-react-native/compare/v6.2.0...v6.3.0) #### What's Changed - chore: update dot lottie documentation by [@​matinzd](https://togithub.com/matinzd) in [lottie-react-native/lottie-react-native#1097 - fix: flickering in dot lottie for Android in Release Mode by [@​ifsnow](https://togithub.com/ifsnow) in [lottie-react-native/lottie-react-native#1100 - chore: check uri scheme instead of BuildConfig.DEBUG by [@​thevoiceless](https://togithub.com/thevoiceless) in [lottie-react-native/lottie-react-native#1101 - chore: bump lottie-ios 4.3.0 by [@​matinzd](https://togithub.com/matinzd) in [lottie-react-native/lottie-react-native#1104 #### New Contributors - [@​thevoiceless](https://togithub.com/thevoiceless) made their first contribution in [lottie-react-native/lottie-react-native#1101 **Full Changelog**: lottie-react-native/lottie-react-native@v6.2.0...v6.3.0 ### [`v6.2.0`](https://togithub.com/lottie-react-native/lottie-react-native/releases/tag/v6.2.0) [Compare Source](https://togithub.com/react-native-community/lottie-react-native/compare/v6.1.2...v6.2.0) #### What's Changed - fix: dot lottie for android in release mode by [@​matinzd](https://togithub.com/matinzd) in [lottie-react-native/lottie-react-native#1091 #### Internal changes - chore: adding swiftlint by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1085 **Full Changelog**: lottie-react-native/lottie-react-native@v6.1.2...v6.2.0 ### [`v6.1.2`](https://togithub.com/lottie-react-native/lottie-react-native/releases/tag/v6.1.2) [Compare Source](https://togithub.com/react-native-community/lottie-react-native/compare/v6.1.1...v6.1.2) #### What's Changed - fix: explicit use of self issue in ContainerView.swift by [@​EKT2000](https://togithub.com/EKT2000) in [lottie-react-native/lottie-react-native#1086 - chore(ci): add ci for ios example build test by [@​matinzd](https://togithub.com/matinzd) in [lottie-react-native/lottie-react-native#1087 #### New Contributors - [@​EKT2000](https://togithub.com/EKT2000) made their first contribution in [lottie-react-native/lottie-react-native#1086 **Full Changelog**: lottie-react-native/lottie-react-native@v6.1.1...v6.1.2 ### [`v6.1.1`](https://togithub.com/lottie-react-native/lottie-react-native/releases/tag/v6.1.1) [Compare Source](https://togithub.com/react-native-community/lottie-react-native/compare/v6.1.0...v6.1.1) #### What's Changed - fix: mark internal methods as private by [@​matinzd](https://togithub.com/matinzd) in [lottie-react-native/lottie-react-native#1077 - fix: unable to determine Swift version by [@​amochkin](https://togithub.com/amochkin) in [lottie-react-native/lottie-react-native#1080 - fix: re-add usage of self for older versions of Xcode with lower versions of Swift by [@​TheRogue76](https://togithub.com/TheRogue76) in [lottie-react-native/lottie-react-native#1084 #### New Contributors - [@​amochkin](https://togithub.com/amochkin) made their first contribution in [lottie-react-native/lottie-react-native#1080 **Full Changelog**: lottie-react-native/lottie-react-native@v6.1.0...v6.1.1 ### [`v6.1.0`](https://togithub.com/lottie-react-native/lottie-react-native/releases/tag/v6.1.0) [Compare Source](https://togithub.com/react-native-community/lottie-react-native/compare/v6.0.1...v6.1.0) #### What's New? - feat: dotLottie support for iOS by [@​matinzd](https://togithub.com/matinzd) in [lottie-react-native/lottie-react-native#1071 - feat: dotLottie support for android by [@​matinzd](https://togithub.com/matinzd) in [lottie-react-native/lottie-react-native#1074 - feat: implement animation failure event by [@​matinzd](https://togithub.com/matinzd) in [lottie-react-native/lottie-react-native#1068 In order to use `.lottie` files in your project, please refer to the documentation provided here: https://github.com/lottie-react-native/lottie-react-native/blob/master/docs/api.md#if-you-want-to-use-lottie-files #### What's Changed - export types from lottie by [@​ethanneff](https://togithub.com/ethanneff) in [lottie-react-native/lottie-react-native#1069 - chore: update bug report template by [@​matinzd](https://togithub.com/matinzd) in [lottie-react-native/lottie-react-native#1076 #### New Contributors - [@​ethanneff](https://togithub.com/ethanneff) made their first contribution in [lottie-react-native/lottie-react-native#1069 **Full Changelog**: lottie-react-native/lottie-react-native@v6.0.1...v6.1.0 ### [`v6.0.1`](https://togithub.com/lottie-react-native/lottie-react-native/releases/tag/v6.0.1) [Compare Source](https://togithub.com/react-native-community/lottie-react-native/compare/v6.0.0...v6.0.1) #### What's Changed - fix: color filters on android by [@​matinzd](https://togithub.com/matinzd) in [lottie-react-native/lottie-react-native#1065 - fix(ios): animation bounding frame with parent view by [@​matinzd](https://togithub.com/matinzd) in [lottie-react-native/lottie-react-native#1062 **Full Changelog**: lottie-react-native/lottie-react-native@v6.0.0...v6.0.1 ### [`v6.0.0`](https://togithub.com/react-native-community/lottie-react-native/blob/HEAD/CHANGELOG.md#600) [Compare Source](https://togithub.com/react-native-community/lottie-react-native/compare/v5.1.6...v6.0.0) ##### Features - Fabric support for iOS ([#​955](https://togithub.com/lottie-react-native/lottie-react-native/pull/955)) - Fabric support for Android ([#​910](https://togithub.com/lottie-react-native/lottie-react-native/pull/910)) - Upgrade android-lottie to 6.0.0 ([#​993](https://togithub.com/lottie-react-native/lottie-react-native/pull/993)) - Upgrade android-lottie to 6.1.0 ([#​1060](https://togithub.com/lottie-react-native/lottie-react-native/pull/1060)) - Implement native auto play for android ([63f71aa](https://togithub.com/react-native-community/lottie-react-native/commit/63f71aacbc007d8e2a9a1216ef2072023dc63fce)) - Implement native auto play for ios ([84e6668](https://togithub.com/react-native-community/lottie-react-native/commit/84e666838075ffb3264a15c823f454cd63d1ab8f)) ##### Bug Fixes - Add missing condition ([bd44aff](https://togithub.com/react-native-community/lottie-react-native/commit/bd44aff93a8e5f992d1414ca9d839b850605eadf)) - Old arch impl ([65ec453](https://togithub.com/react-native-community/lottie-react-native/commit/65ec453afa1663fcb564a21931af7f27531c106b)) - **android**: Refactor event dispatch logic on android to fix fabric crash ([#​1000](https://togithub.com/react-native-community/lottie-react-native/issues/1000)) ([ebb8006](https://togithub.com/react-native-community/lottie-react-native/commit/ebb8006da0385e44bb33817d44909376143a1695)) - **android**: Add support for upcoming 0.73 ([#​1038](https://togithub.com/lottie-react-native/lottie-react-native/pull/1038)) - **android**: Fix resize mode in Android ([#​992](https://togithub.com/lottie-react-native/lottie-react-native/pull/992)) - **iOS**: Reset to first frame on app resume bug ([#​980](https://togithub.com/lottie-react-native/lottie-react-native/pull/980)) - **iOS**: Frames being calculated incorrectly ([#​1019](https://togithub.com/lottie-react-native/lottie-react-native/pull/1019)) - **macOS**: react native macos build ([#​1031](https://togithub.com/lottie-react-native/lottie-react-native/pull/1031)) - **iOS**: Memory leak on deallocation ([#​1055](https://togithub.com/lottie-react-native/lottie-react-native/pull/1055)) - **iOS**: Update lottie-ios to 4.2.0 + fix build error ([#​1036](https://togithub.com/lottie-react-native/lottie-react-native/pull/1036)) - **iOS**: prevent jumping to end frame ([#​1061](https://togithub.com/lottie-react-native/lottie-react-native/pull/1061)) - Fabric build on 0.68/0.69 ([#​1054](https://togithub.com/lottie-react-native/lottie-react-native/pull/1054)) - Fix different ios related issues ([3f7e3e](https://togithub.com/lottie-react-native/lottie-react-native/commit/3f7e3e6aebf24daa052c9552ab96489c1fa4a547)) ##### Internal Changes - Move project to monorepo [077429](https://togithub.com/lottie-react-native/lottie-react-native/commit/077429f164502b955063a2eaeb4321ba4ec5d95d) - Update examples to typescript ([300e63](https://togithub.com/lottie-react-native/lottie-react-native/commit/300e633f0261942e5ead8fa4335dd09afb583dd9)) - Remove redundant logging from the project ([#​1024](https://togithub.com/lottie-react-native/lottie-react-native/pull/1024)) ##### BREAKING CHANGES - BREAKING CHANGE: Removed using Animated API by default in the source code ([#​992](https://togithub.com/lottie-react-native/lottie-react-native/pull/992)) - BREAKING CHANGE: Removed absolute style being applied to the LottieView ([#​992](https://togithub.com/lottie-react-native/lottie-react-native/pull/992)) - BREAKING CHANGE: Removed default aspect ratio styling ([#​992](https://togithub.com/lottie-react-native/lottie-react-native/pull/992)) - BREAKING CHANGE: Removed default width and height being applied ([#​992](https://togithub.com/lottie-react-native/lottie-react-native/pull/992)) Check [here](https://togithub.com/lottie-react-native/lottie-react-native/pull/992) for more information. - BREAKING CHANGE: Renamed AnimatedLottieViewProps to LottieViewProps ([9fd591](https://togithub.com/lottie-react-native/lottie-react-native/commit/9fd591fd7f864fdbf5235ba35d0a7240ec9ab360)) Full changelog can be found [here](https://togithub.com/react-native-community/lottie-react-native/compare/v5.1.5...v6.0.0). ##### Known issues: - Initial render with json source is not always working as expected on iOS when new architecture is turned on ([lottie-react-native/lottie-react-native#1043) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMwMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tom McGuire <mcgtom10@gmail.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue: #1114