-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crazy train 20201012 #346
Merged
Merged
Crazy train 20201012 #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an initial commit towards eliminating pointers from user code, deriving a more stable ABI, and eliminating the uses of friend classes.
Towards reducing size of WorldImpl.cpp.
Towards removing uses of friend classes that are no longer needed due to the new WorldImpl design,
Towards removing uses of friend classes that are no longer needed due to the new WorldImpl design.
Towards removing uses of friend classes that are no longer needed due to the new WorldImpl design.
Towards removing uses of friend classes that are no longer needed due to the new WorldImpl design.
WorldImpl class is meant to be self-contained "basis" code for free functions; not the other way around. Removing these includes helps ensure that. And it recognized a need for ComputeMassData being a basis member function as well so it was added.
From switching pointers to indices which are smaller.
This was referenced Oct 18, 2020
This was referenced Oct 18, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
For issues or changes that describe or fix bugs.
Docs
Use when issue or pull request relates to the documentation of the project.
Enhancement
For suggestions or changes that enhance any part of the project and isn't a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description - What's this PR do?
Major changes:
Impacts/Risks of These Changes?
Introduces a number of API breaking changes but at the benefit of providing a new ABI stable interface.
Any background context you want to provide?
This addresses many major project goals.
Related Issues