Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push - Change default string "true" to "up" #1593

Closed
2 tasks done
AntonyGarand opened this issue Apr 29, 2022 · 0 comments
Closed
2 tasks done

Push - Change default string "true" to "up" #1593

AntonyGarand opened this issue Apr 29, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@AntonyGarand
Copy link

AntonyGarand commented Apr 29, 2022

⚠️ Please verify that this bug has NOT been raised before.

  • I checked and didn't find similar issue

🛡️ Security Policy

Description

Under push monitors, the default generated URL for the push monitor has the status=true string, but the api checks for up instead.

server/routers/api-router.js:37

        let statusString = request.query.status || "up";
        let status = (statusString === "up") ? UP : DOWN;

src/pages/EditMonitor.vue:424

        pushURL() {
            return this.$root.baseURL + "/api/push/" + this.monitor.pushToken + "?status=true&msg=OK&ping=";
        },

I would recommend changing the default message to be status=up instead.

👟 Reproduction steps

Create a push monitor, copy its id

👀 Expected behavior

The default status should be "up"

😓 Actual Behavior

The status of "true" registers as "down"

🐻 Uptime-Kuma Version

1.15.1

💻 Operating System and Arch

Any

🌐 Browser

Firefox

🐋 Docker Version

No response

🟩 NodeJS Version

No response

📝 Relevant log output

No response

@AntonyGarand AntonyGarand added the bug Something isn't working label Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant