Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Weblate commit details #4382

Closed
2 tasks done
kindercat opened this issue Jan 17, 2024 · 14 comments · Fixed by #4386
Closed
2 tasks done

Changing Weblate commit details #4382

kindercat opened this issue Jan 17, 2024 · 14 comments · Fixed by #4386
Labels
area:core issues describing changes to the core of uptime kuma help

Comments

@kindercat
Copy link
Contributor

⚠️ Please verify that this question has NOT been raised before.

  • I checked and didn't find similar issue

🛡️ Security Policy

📝 Describe your problem

I saw the Weblate commits for all languages and I'm wondering if I can edit a commit details like email address.

📝 Error Message(s) or Log

No response

🐻 Uptime-Kuma Version

1.23.10

💻 Operating System and Arch

Ubuntu 22.04.3

🌐 Browser

Microsoft Edge latest

🐋 Docker Version

No response

🟩 NodeJS Version

No response

@kindercat kindercat added the help label Jan 17, 2024
@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Jan 17, 2024

You are likely referring to this, right? 755c92c
Is the email address incorrect?

We could create a .mailmap, but for this we need a bit more context ^^

@CommanderStorm CommanderStorm added the area:core issues describing changes to the core of uptime kuma label Jan 17, 2024
@kindercat
Copy link
Contributor Author

kindercat commented Jan 17, 2024

I've done some testing on Weblate in the mail section and I think it will be a good idea if the commits can be linked to the no-reply identity from github to avoid spam.
And of course, if this identity is linked, the github profile should also be displayed. If you check the next commit, another identity is selected but the github profile is not linked.

@CommanderStorm
Copy link
Collaborator

If you use an identity which I assume is not linked+verified to/for your account, like kindercat@users.noreply.weblate.kuma.pet, this will not be linked to your account as far as I understand

@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Jan 17, 2024

we can add this as an alias for [REDACTED]@gmail.com in a .mailmap, but I sort of doubt that this achives what you want...

Note that spam is not a real issue.
I have not seen more spam in my mailbox from contributing actively on GitHub. The only spam I receive can be traced back to stupid things I did in the past and being included in data leaks.

@kindercat
Copy link
Contributor Author

If you can edit the commit and this issue with the weblate or github identity is ok for me :)

I really appreciate this project and I want to help more.

@CommanderStorm
Copy link
Collaborator

Editing commits is a medium pain and requires rebasing.
cc @louislam given that you manage weblate ^^

This is the mentiended commit d680858

@kindercat
Copy link
Contributor Author

This is the commit I wanted to edit 755c92c
Also please don't forget to edit the post from above :)

Thanks!

@CommanderStorm
Copy link
Collaborator

Also please don't forget to edit the post from above

What post?

@kindercat
Copy link
Contributor Author

This one #4382 (comment)

@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Jan 17, 2024

So you want your weblate contributions to not be displayed on github?
=> both commits to have kindercat@users.noreply.weblate.kuma.pet instead?

@kindercat
Copy link
Contributor Author

Yes. Only the username is ok for me.
You can use kindercat@users.noreply.weblate.kuma.pet or no-reply identity from github.

@louislam
Copy link
Owner

Unfortunately, Weblate don't let me to control the git repo either. There are only two actions I can do: Commit and Push, which do not seem to be able to change the commit message.

image

@louislam
Copy link
Owner

Maybe I can merge #4270 to a temporary branch, and rebase your commit before merging to the main branch.

@kindercat
Copy link
Contributor Author

kindercat commented Jan 17, 2024

Maybe this is usefull https://youtu.be/BNF4le5X1Ms?si=UtLIOdp8q50plFk_
If not, it's not that bad.. just delete this issue and I'm fine.

In the meanwhile I just saw the last commit with the github no-reply identity and it's linked. So that is the correct option to select.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core issues describing changes to the core of uptime kuma help
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants