Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings proxy import / export #4465

Closed
jacoballen55 opened this issue Feb 8, 2024 · 5 comments
Closed

settings proxy import / export #4465

jacoballen55 opened this issue Feb 8, 2024 · 5 comments
Labels
area:settings Related to Settings page and application configration feature-request Request for new features to be added wontfix This will not be worked on

Comments

@jacoballen55
Copy link

πŸ“‘ I have found these related issues/pull requests

there is no option for proxies import. I raised this last year but no response.

🏷️ Feature Request Type

Settings

πŸ”– Feature description

adding proxy import would be good.

βœ”οΈ Solution

adding in settings to setup new proxy import in format
ip:port:username:password

❓ Alternatives

No response

πŸ“ Additional Context

No response

@jacoballen55 jacoballen55 added the feature-request Request for new features to be added label Feb 8, 2024
@CommanderStorm CommanderStorm added question Further information is requested area:settings Related to Settings page and application configration labels Feb 8, 2024
@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Feb 8, 2024

Proxy backup

I raised this last year but no response.

Not true, #2426 was closed as the backup feature introduced too many bugs and was unmaintainable.
Please see #2141 (comment):

In 1.18.3, the backup feature was deprecated due to [being left] unmaintained.

Backup & Restore with JSON has been deprecated and issues will not be fixed due to the amount of problems it has been causing for our users and us.
The current design is just not maintainable, causing countless bugs.
In v2.0 the deprecated backup tool is being removed because of this reason.
Please consider using SQL, API based1 or infrastructure based2 backup instead.

New approaches to these features should use SQLite dump or MariaDB dump respectively. (Here is our contribution guide)

You can subscribe to these issues meanwhile:

Footnotes

  1. using the third-party API: https://uptime-kuma-api.readthedocs.io/en/latest/ ↩

  2. see https://github.com/louislam/uptime-kuma/issues/477#issuecomment-1557966187 for a setup example ↩

@CommanderStorm
Copy link
Collaborator

Proxy import

Why do you need this?
I am not quite convinced that adding such a feature would benefit the general user, as (at least the way I think our users use proxies => see #4456 for a relevant discussion)

I think the third party API might be a better fit1 for your use case (you did not specify the WHY).

Footnotes

  1. https://uptime-kuma-api.readthedocs.io/en/latest/api.html#uptime_kuma_api.UptimeKumaApi.add_proxy ↩

@bcookatpcsd
Copy link

.. just wanted to add

K12 here.. 10 buildings.. heavy into proxying..

Migrated from a docker uptime-kuma to a standalone for db/latency issues..

Seems all the 'proxy checks' we had on defined hosts were not the the backup/migrations (in whatever state that is in)

It was not clear they were not in all that we migrated/moved.

@CommanderStorm
Copy link
Collaborator

@bcookatpcsd I don't fully know what you wanted to add.
Your comment does not go into why adding this via the thrid party API (#4465 (comment)) is not a better fit.

Migrated from a docker uptime-kuma to a standalone for db/latency issues

I don't know what you are trying to do, but docker and standalone should not have latency differences to access the SQLite database. If you are trying to access an external DB to execute checks on, the latency should also be basically the same.

If you are trying to run many monitors (~500 on regular disks) or have lots of retention configured, the proper fix for this is to upgrade to v2.0 (or 1.23.X if you have not yet, there are some fixes in said release such as incremental vacuum) once it is out.
We have made some deep performance improvements, like storing data in an aggregated form.

It was not clear they were not [in the backup]

That is why this feature will get removed in v2.0 as stated in #4465 (comment).
I think the warning on the backup page is enough to discourage the usage or to not expect that the export will be complete:

deprecation warning on the Settings > Backup

image

@CommanderStorm CommanderStorm added wontfix This will not be worked on and removed question Further information is requested labels Jun 1, 2024
@CommanderStorm
Copy link
Collaborator

I think my argument from above why this can and should be solved via the third party api, the third party cli or in the future also the first party api (#118).
I don't see a reason for a dedicated proxy export/import to exist.
=> closing as not planned.

If I am missing a part, we can reopen this issue.

@CommanderStorm CommanderStorm closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:settings Related to Settings page and application configration feature-request Request for new features to be added wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants