Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[change] Move i18n from Security to locale files #1777

Merged

Conversation

MarcHagen
Copy link
Contributor

@MarcHagen MarcHagen commented Jun 15, 2022

Description

Moving al language blocks from the Security page to there language files

The <!-- eslint-disable-next-line vue/no-v-html --> are there to suppress the warning from eslint.
https://eslint.vuejs.org/rules/no-v-html.html
https://kazupon.github.io/vue-i18n/guide/formatting.html#html-formatting

Also gathering feedback if this is the way to do it. Or maybe someone else has a genius idea!

The reason that i did not put the full English string in the language files is the lenght.
If this is not what we want, i'll change it any second :)

Type of change

Please delete any options that are not relevant.

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)
  • Translation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

@louislam
Copy link
Owner

Thanks! That was my misuse of vue-i18n.

It is allowed to use v-html in this case.

@MarcHagen MarcHagen marked this pull request as ready for review June 16, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants