Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cacheable-lookup #1853

Merged
merged 8 commits into from
Jul 18, 2022
Merged

Add cacheable-lookup #1853

merged 8 commits into from
Jul 18, 2022

Conversation

louislam
Copy link
Owner

Description

Follow up of #1823.

cacheable-lookup is a 5M weekly downloads library, I think it is more stable.

  • As proxy and https are using custom agent, need to find a way to hook up cachable-lookup.

Type of change

Please delete any options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

@louislam louislam marked this pull request as draft June 29, 2022 14:28
@louislam
Copy link
Owner Author

As it is not able to add to proxy http agent, this pr for non-proxy only.

@louislam louislam marked this pull request as ready for review July 18, 2022 15:36
@louislam louislam merged commit 9a8b484 into master Jul 18, 2022
@louislam louislam mentioned this pull request Aug 17, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant