Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ntfy notifications #2863

Merged
merged 2 commits into from Apr 9, 2023

Conversation

mtelgkamp
Copy link
Contributor

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Improve ntfy notifications.

  • use tags red_circle for down and green_circle for up
  • increase priority for down alert by 1 if not already max
  • add monitor name and status to title
  • use heartbeat msg as Message
  • add monitor url as action

Type of change

  • Other (improve notification provider)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

screenshot ntfy alert

- use tags `red_circle` for down and `green_circle` for up
- increase priority for down alert by 1 if not already max
- add monitor name and status to title
- use heartbeat msg as Message
- add monitor url as action
@louislam louislam added this to the 1.22.0 milestone Mar 2, 2023
@mabed-fr
Copy link

mabed-fr commented Mar 3, 2023

Hello

Good job !

Why not replace "keyword" with the word actually searched by the probe/check?

@mtelgkamp
Copy link
Contributor Author

Good job !

Thank you

Why not replace "keyword" with the word actually searched by the probe/check?

I use the variable heartbeatJSON.msg for the message, so changes to the text are not part of the notification, but need to be done where the variable is filled, to change the text for all notification providers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants