Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use safeBeat in push monitor #3174

Merged
merged 1 commit into from Jul 13, 2023

Conversation

chakflying
Copy link
Collaborator

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #3130

Normally, a monitor is able to "heal" itself following an error because of the use of safeBeat. Following investigation in #3130, error in push monitor causes the monitor to fail and not restart. Switching to safeBeat solves the issue. I tested this by adding to Math.random() call to throw error after saving to database.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@CommanderStorm
Copy link
Collaborator

Could you please go into detail how you tested this PR? I am unclear what you added where to test it.

Do you think this case would make a good unittest to prevent regressions in the future?

@louislam louislam added this to the 1.23.0 milestone Jun 24, 2023
@louislam louislam merged commit e7d1b4e into louislam:master Jul 13, 2023
16 checks passed
@chakflying chakflying deleted the fix/push-monitor-safe-restart branch July 18, 2023 06:11
@CommanderStorm CommanderStorm mentioned this pull request Aug 13, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitors are stopped after database is locked error
3 participants