Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Set radius connection timeout to monitor default #3188

Merged
merged 1 commit into from Jul 9, 2023

Conversation

chakflying
Copy link
Collaborator

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #3185. Untested. If the monitor timeout becomes configurable in the future this can be passed the same variable.

While searching for the documentation of node-radius-client, I found out the repository that npm pointed to has disappeared from public view (https://github.com/w3cj/node-radius-client). IMO this is a pretty bad situation as we will be unable to raise issues if any were found. But there seems to be no alternative to this package so I guess we will have to stick to the status quo.

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

@louislam louislam added this to the 1.23.0 milestone Jun 24, 2023
@louislam louislam merged commit d825dbf into louislam:master Jul 9, 2023
16 checks passed
@chakflying chakflying deleted the fix/radius-timeout branch July 18, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make RADIUS timeout value configurable
3 participants