Skip to content

Added fix to remove children when type changed - #3311

Merged
louislam merged 1 commit into
louislam:masterfrom
tarun7singh:monitor-group-fix
Jun 26, 2023
Merged

louislam merged 1 commit into
louislam:masterfrom
tarun7singh:monitor-group-fix

Conversation

@tarun7singh

Copy link
Copy Markdown
Contributor

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #3262

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings

Screenshots (if any)

2 Monitors in a group

Screenshot 2023-06-25 at 10 32 45 PM

Monitors unlinked after changing type

Screenshot 2023-06-25 at 10 36 26 PM

@louislam
louislam merged commit 9fb8f94 into louislam:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug when editing monitor(type group)

2 participants