Feat: Toast notification timeout settings #3441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thinking about this, it's probably not a good idea for the setting to affect the system messages. Changed back to the setting affecting monitor toast notifications only. |
chakflying
force-pushed
the
toast-notification-timeout-setting
branch
from
b909882
to
49ecad4
Compare
Computroniks
suggested changes
Aug 5, 2023
|
Are there any instructions for building the docker image from source? I looked but I can only find npm instructions, and my current setup is through docker. I'd like to give this PR a try as it's a feature I'm looking forward to. |
|
You should be able to use the pre built docker image for this PR by following these instructions in the wiki |
chakflying
force-pushed
the
toast-notification-timeout-setting
branch
from
3e70253
to
b096586
Compare
Changing gui, adding timeout with a fix value memo rc rollback readme cleanup code cleanup code Review fixes review fix 2
Chore: Remove unused
Co-authored-by: Matthew Nickson <mnickson@sidingsmedia.com>
chakflying
force-pushed
the
toast-notification-timeout-setting
branch
from
837b5cc
to
65993e3
Compare
7 tasks
2 tasks
2 tasks
CommanderStorm
added
the
area:dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #2116
Fixes #1178
Fixes #1085
Fixes #841
This is a continuation of #2555, with various changes applied to improve usability and code organization.
Settings is stored to
localStorageon change, so the "Save" button is not needed. Settings are applied to the toast instance default, which will apply to all toast notifications of the same type.A new button to clear all toast notification is added to the bottom of the toasts stack. The individual close button for each toast is set to show on hover since the close all button should satisfy most needs.
Type of change
Checklist
(including JSDoc for methods)
Screenshots (if any)