Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to pass cache bust param #3525

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add option to pass cache bust param #3525

wants to merge 11 commits into from

Conversation

dansullivan86
Copy link

@dansullivan86 dansullivan86 commented Aug 4, 2023 •
edited
Loading

  • I have read and understand the pull request rules.

Description

Fixes #575

Type of change

Please delete any options that are not relevant.

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

CommanderStorm
CommanderStorm requested changes Aug 4, 2023
View reviewed changes
server/model/monitor.js Outdated Show resolved Hide resolved
src/lang/en.json Outdated Show resolved Hide resolved
server/model/monitor.js Show resolved Hide resolved
CommanderStorm
CommanderStorm reviewed Aug 4, 2023
View reviewed changes
src/lang/en.json Outdated Show resolved Hide resolved
Computroniks
Computroniks reviewed Aug 5, 2023
View reviewed changes
server/model/monitor.js Outdated Show resolved Hide resolved
server/model/monitor.js Show resolved Hide resolved
@louislam louislam added this to the 2.0.0 milestone Aug 7, 2023
louislam
louislam reviewed Sep 9, 2023
View reviewed changes
server/database.js
@@ -79,6 +79,7 @@ class Database {
"patch-added-kafka-producer.sql": true,
"patch-add-certificate-expiry-status-page.sql": true,
"patch-monitor-oauth-cc.sql": true,
"patch-add-cache-bust.sql": true,
Copy link
Owner

@louislam louislam Sep 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is deprecated. Need to use knex migrations

https://github.com/louislam/uptime-kuma/tree/master/db/knex_migrations

@louislam louislam added the question Further information is requested label Sep 9, 2023
@louislam louislam modified the milestones: 2.0.0, 2.1.0 Oct 16, 2023
@CommanderStorm CommanderStorm added the area:monitor Everything related to monitors label Dec 8, 2023
@CommanderStorm CommanderStorm mentioned this pull request Jan 17, 2024
Open
1 task
@CommanderStorm CommanderStorm added the needs:review this PR needs a review by maintainers or other community members label May 19, 2024
@CommanderStorm CommanderStorm modified the milestones: 2.1.0, 2.0.0 May 23, 2024
@CommanderStorm CommanderStorm added needs:work this PR needs work needs:resolve-merge-conflict A merge-conflict needs to be addressed before reviewing makes sense again and removed needs:review this PR needs a review by maintainers or other community members labels May 23, 2024
@github-actions github-actions bot removed the needs:resolve-merge-conflict A merge-conflict needs to be addressed before reviewing makes sense again label May 23, 2024
CommanderStorm

This comment was marked as resolved.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louislam louislam louislam left review comments

@CommanderStorm CommanderStorm CommanderStorm requested changes

@Computroniks Computroniks Computroniks left review comments

Assignees
No one assigned
Labels
area:monitor Everything related to monitors needs:work this PR needs work question Further information is requested
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Add option to pass a cachebusting parameter
5 participants
@dansullivan86 @louislam @CommanderStorm @Computroniks @dansullivan86sym