Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 fix: kafka producer bugs #3771

Merged
merged 2 commits into from Sep 23, 2023

Conversation

mhkarimi1383
Copy link
Contributor

鈿狅笍鈿狅笍鈿狅笍 Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

I have refactored kafka producer error handling, also fixed ssl checkbox problem in UI

Fixes #3760

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@louislam louislam added this to the 1.23.3 milestone Sep 19, 2023
@louislam louislam changed the base branch from master to 1.23.X September 21, 2023 11:41
@louislam louislam changed the base branch from 1.23.X to master September 21, 2023 11:46
Signed-off-by: Muhammed Hussein Karimi <info@karimi.dev>
Signed-off-by: Muhammed Hussein Karimi <info@karimi.dev>
@louislam louislam changed the base branch from master to 1.23.X September 21, 2023 11:53
@louislam louislam merged commit 2ab21cc into louislam:1.23.X Sep 23, 2023
14 checks passed
@mhkarimi1383 mhkarimi1383 deleted the fix-kafka-producer-bugs branch September 24, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitor Kafka Producer Enable Kafka SSL disabled after checking box and saving
2 participants