Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grammar #4087

Closed
wants to merge 1 commit into from
Closed

fix: grammar #4087

wants to merge 1 commit into from

Conversation

wdhdev
Copy link
Contributor

@wdhdev wdhdev commented Nov 23, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes the grammar for the no monitors text.

Type of change

Please delete any options that are not relevant.

  • Other

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@louislam louislam added the question Further information is requested label Nov 23, 2023
@louislam
Copy link
Owner

Language files cannot be touched in any pull requests, because it will create a big code conflict with Weblate.

Please update it on https://weblate.kuma.pet/projects/uptime-kuma/uptime-kuma/

@Zaid-maker
Copy link
Contributor

Language files cannot be touched in any pull requests, because it will create a big code conflict with Weblate.

Please update it on https://weblate.kuma.pet/projects/uptime-kuma/uptime-kuma/

Yes correct i think u should close it ig!

@chakflying
Copy link
Collaborator

  • this is not a grammar problem
  • there is no point in "fixing" the language key itself

@louislam louislam closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants