-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit Testing monitors with Testcontainers #4451
Draft
CommanderStorm
wants to merge
13
commits into
louislam:master
Choose a base branch
from
CommanderStorm:testcontainers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
7 tasks
Interesting. It is able to run on GitHub Actions? |
Yes I guess so I tried it once |
I don't see a reason why it cannot. |
This was referenced Feb 11, 2024
6 tasks
chakflying
changed the title
Testing of monitors
Unit Testing monitors with Testcontainers
Mar 2, 2024
7 tasks
CommanderStorm
added
the
pr:please address review comments
this PR needs a bit more work to be mergable
label
May 19, 2024
github-actions
bot
added
pr:please resolve merge conflict
A merge-conflict needs to be addressed before reviewing makes sense again
and removed
pr:please resolve merge conflict
A merge-conflict needs to be addressed before reviewing makes sense again
labels
May 19, 2024
github-actions
bot
added
pr:please resolve merge conflict
A merge-conflict needs to be addressed before reviewing makes sense again
and removed
pr:please resolve merge conflict
A merge-conflict needs to be addressed before reviewing makes sense again
labels
May 22, 2024
tested if a different clenup order can fix `Promise resolution is still pending but the event loop has already resolved` tested different way of running multi-tests Fixed `Error: Cannot find module @rollup/rollup-linux-arm64-gnu. npm has a bug related to optional dependencies (npm/cli#4828). Please try `npm i` again after removing both package-lock.json and node_modules directory` removed the currently not needed `testcontainers` package fixed rebasing issues in the package-lock.json
CommanderStorm
force-pushed
the
testcontainers
branch
from
May 23, 2024 23:02
3bd8785
to
1cc01c9
Compare
github-actions
bot
removed
the
pr:please resolve merge conflict
A merge-conflict needs to be addressed before reviewing makes sense again
label
May 23, 2024
github-actions
bot
added
the
pr:please resolve merge conflict
A merge-conflict needs to be addressed before reviewing makes sense again
label
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:monitor
Everything related to monitors
needs:resolve-merge-conflict
pr:please address review comments
this PR needs a bit more work to be mergable
pr:please resolve merge conflict
A merge-conflict needs to be addressed before reviewing makes sense again
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
This issue is meant as a discussion.
I have thought a bunch about how our monitors can be tested and have come to the conclusion that for most monitors, testcontainers seem like a good fit.
Testing this part would allow us to merged PRs like #4445 or #4393 without the risk or the level of manual verification required.
Things that we should discuss:
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)
<- screenshot of testcases passing ->