Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use version name instead of testing #4867

Closed
wants to merge 1 commit into from
Closed

Conversation

p00rt
Copy link

@p00rt p00rt commented Jun 19, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

when trying to build from the debian base image, you get a dependency conflict and are unable to build because the image is based on bookworm but the Dockerfile adds testing repositories which are currently trixie not bookworm. This change makes sure we only use bookworm at all times.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

@CommanderStorm
Copy link
Collaborator

Problem with the proposed change is that this debumps apprise a lot...

See https://tracker.debian.org/pkg/apprise:

v1.2.0 was back in November 2022..

@louislam
Copy link
Owner

Omg, is there any "lock mechanism" like npm's package-lock.json in apt?

@louislam louislam marked this pull request as draft June 20, 2024 10:59
@CommanderStorm CommanderStorm added area:deployment related to how uptime kuma can be deployed needs:work this PR needs work labels Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:deployment related to how uptime kuma can be deployed needs:work this PR needs work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants