Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate Docker Releases with GitHub Actions #53

Closed
wants to merge 2 commits into from
Closed

Automate Docker Releases with GitHub Actions #53

wants to merge 2 commits into from

Conversation

tiemonl
Copy link

@tiemonl tiemonl commented Jul 14, 2021

Hi, I'm not sure if this is something you wanted or not, but I thought I would offer it up as a solution as I saw this in the README:

PS: For every new release, it takes some time to build the docker image, please be patient if it is not available yet.

All that is needed from you is to put a docker access token in the actions secrets named DOCKER_TOKEN. This will push on a new release to docker hub and GHCR (I thought I'd add it as i've seen some people prefer it over docker hub) when a new tag is created in the format of v* (what you're currently using). If you have any questions, please let me know. Also, feel free to close this PR if this is not something you're interested in.

@louislam
Copy link
Owner

Thank you.

But I prefer to build on my machine for now. I need to build for 3 platforms amd64/armv7/arm64. It takes 30 mins to finish even on my 3900x machine without cache layer, due to compiling sqlite for arm platforms.

I tried autobuild on Docker Hub before, it is even slower. I guess Github Action will be similar.

@tiemonl
Copy link
Author

tiemonl commented Jul 15, 2021

I can look into automating that as well if that interests you? If not, I can let it go. Let me know?

@proffalken
Copy link
Contributor

But I prefer to build on my machine for now. I need to build for 3 platforms amd64/armv7/arm64. It takes 30 mins to finish even on my 3900x machine without cache layer, due to compiling sqlite for arm platforms.

I tried autobuild on Docker Hub before, it is even slower. I guess Github Action will be similar.

@louislam - Github Actions takes about the same amount of time (around 30m) for me on both proffalken/mventory and makemonmouth/mmbot, but having it automated really does make my life a lot easier.

Take a look at https://github.com/MakeMonmouth/mmbot/blob/main/.github/workflows/container_build.yml for a full setup, all you'd need to do is change https://github.com/MakeMonmouth/mmbot/blob/main/.github/workflows/container_build.yml#L34 to ghcr.io/louislam/uptime-kuma or similar and it would automatically build for multiple architectures and push to the Github Container Registry.

Using GHA is completely free for the first 2000 minutes of build time each month, and unlike Dockerhub Github Container Registry doesn't have a limit on the number of times a container can be downloaded.

MMBot is released under the MIT license, so you're more than welcome to just copy/paste :)

@louislam louislam added feature-request Request for new features to be added priority:low Low Priority labels Jul 20, 2021
@proffalken
Copy link
Contributor

@tiemonl - apologies for stepping on your toes with #213 however I didn't want to start overwriting your code and I'd love to start referring to this container as kuma-uptime:latest in my Nomad manifests so I constantly get the most up to date version.

The code in #213 also creates a container for each PR so if someone wants to test it in their environments they can do so!

@Aummpoo
Copy link

Aummpoo commented Aug 26, 2021

Cb514895

@Saibamen
Copy link
Contributor

Related issue: #440

@gaby
Copy link
Contributor

gaby commented Sep 20, 2021

@louislam I'd say this PR can be close in favor of #213 which also covers building for different platforms.

@tiemonl
Copy link
Author

tiemonl commented Sep 20, 2021

Closing in favor of #213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features to be added priority:low Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants