Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Native Abstractions #1

Closed
lovell opened this issue Aug 21, 2013 · 1 comment
Closed

Use Native Abstractions #1

lovell opened this issue Aug 21, 2013 · 1 comment

Comments

@lovell
Copy link
Owner

lovell commented Aug 21, 2013

There are compiler warnings with node v0.11 unstable.

../src/sharp.cc: In function ‘v8::Handle<v8::Value> Resize(const v8::Arguments&)’:
../src/sharp.cc:159:77: warning: ‘static v8::Persistent<S> v8::Persistent<T>::New(v8::Handle<T>) [with T = v8::Function]’ is deprecated (declared at /home/travis/.node-gyp/0.11.3/deps/v8/include/v8.h:5514) [-Wdeprecated-declarations]

Using https://github.com/rvagg/nan should hopefully reduce the impact of V8 changes, e.g. https://github.com/rvagg/node-postgres/commit/6cb167112ef65845dec818e7a888218fbe408483

@lovell
Copy link
Owner Author

lovell commented Apr 2, 2014

Thank you to @pierreinglebert for implementing this - see PR #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant