Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.11 compat using nan #11

Merged
merged 2 commits into from
Apr 2, 2014
Merged

0.11 compat using nan #11

merged 2 commits into from
Apr 2, 2014

Conversation

pierreinglebert
Copy link
Contributor

For #1

I changed some calls and I used NanAsyncWorker instead of playing with uv_work and persistent, it says there are 250 changes (due to code move) but I think it's more 30-50.

Works well for me on 0.11.10 (newer release are still buggy with native mods).

@lovell
Copy link
Owner

lovell commented Apr 2, 2014

Thank you for working on this @pierreinglebert, much appreciated.

Does the epeg module fail to compile on Node.js 0.11? If so, this should probably be removed in its entirety rather than be commented out.

I'll take a closer look at the other changes with a different diff and report back here.

@pierreinglebert
Copy link
Contributor Author

Yes i forgot to mention that epeg doesn't work on 0.11

@lovell
Copy link
Owner

lovell commented Apr 2, 2014

Looks good to me, thank you again for doing this @pierreinglebert, especially as v0.12 will be arriving “as soon as humanly possible”.

lovell added a commit that referenced this pull request Apr 2, 2014
Add support for Node.js v0.11+ via nan. Remove epeg test dependency as it fails to compile on v0.11+.
@lovell lovell merged commit fe77373 into lovell:master Apr 2, 2014
@lovell lovell mentioned this pull request Apr 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants