Error when combining rotate and sequentialRead

[joesong168]

ERROR VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
VipsJpeg: out of order read at line 3840
key:largeExif.jpg

What are the steps to reproduce?

await image
.rotate()
.sequentialRead
.tiff({ pyramid: true, tile: true, tileWidth: 512, tileHeight: 512 })
.toBuffer()

What is the expected behaviour?

normal buffer

Are you able to provide a sample image that helps explain the problem?

https://s3.cn-northwest-1.amazonaws.com.cn/iiif.etu.wiki/largeExif.jpg

[lovell]

Hi, this should work if you remove the use of sequentialRead().

Adding the rotate operation to the list of exceptions where we know sequentialRead could fail will also prevent this. You'll notice trim, normalise and some of the crop strategies already follow this pattern:

sharp/src/pipeline.cc

Lines 1417 to 1422 in 755a0ca

	// Force random access for certain operations
	if (baton->accessMethod == VIPS_ACCESS_SEQUENTIAL && (
	baton->trimThreshold > 0.0 || baton->normalise ||
	baton->position == 16 || baton->position == 17)) {
	baton->accessMethod = VIPS_ACCESS_RANDOM;
	}

Happy to accept a PR if you're able.

[lovell]

v0.24.0 is now available with the fix for this. Thanks for reporting!