Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with ICC profile - different result from Photoshop #3036

Closed
arthurmchr opened this issue Jan 10, 2022 · 3 comments
Closed

Problem with ICC profile - different result from Photoshop #3036

arthurmchr opened this issue Jan 10, 2022 · 3 comments
Labels

Comments

@arthurmchr
Copy link

When I load an image without ICC profile with a RGB color space in sharp, and then apply a custom profile to it, I am not getting the same result as I got under Photoshop.
In sharp the colors are the same with or without the profile, whereas in Photoshop applying a profile to a photo without an existing profile will change the colors. Is there any way to get the same result in sharp ?

Thanks !

What I am actually doing :

sharp('no-profile.jpg')
    .withMetadata({ icc: './rgb-adobe-1998.icc' })
    .toFile('with-profile.jpg')

Input image :
no-profile

Result in sharp : (except compression, same colors)
with-profile

Result in Photoshop after applying adobe 1998 icc :
photoshop-with-profile-adobe1998

@lovell
Copy link
Owner

lovell commented Jan 10, 2022

Hi, I'm unsure if applying (assigning?) a profile to an image in Photoshop is the same as converting an image to use that profile. What process did you use?

As you say, the example input is profile-less sRGB, and sharp opens it as such. When you save with the Adobe profile, the pixel values are converted to match that profile. This means that when the new image is opened, it should look very close to the original sRGB version. (The blockiness in the second sample image is due to it having a lower quality and using chroma subsampling.)

I think what you nay be looking for is the ability to open an image with a custom profile, which is covered by the future possible enhancement at #1324

@arthurmchr
Copy link
Author

Hi, thanks for your explanation and your time.
You are right, under Photoshop it is "assigning a profile" (under the Edition tab).

@lovell
Copy link
Owner

lovell commented Jan 10, 2022

I think "assign profile" is equivalent to "open this image as if it had this profile" so let's track this at #1324

@lovell lovell closed this as completed Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants