Adding mention of max() to preserve ratio in withoutEnlargement #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for your PR. The |
|
Silly me, of course, and sorry.
…On 24 December 2017 at 23:00, Lovell Fuller ***@***.***> wrote:
Hello, thank you for your PR. The docs/api-*.md files are autogenerated
from JSDoc comments in the source code. Are you able to make these changes
to the comments in the resize source
<https://github.com/lovell/sharp/blob/master/lib/resize.js#L252-L261>
instead?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1077 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACB7XktcZik-7Zubpjn_vhslRTiRoYHGks5tDmcJgaJpZM4RLy8i>
.
|
Reverted change to (generated) doc file
|
Done and sorry for taking so long |
|
No worries, thank you! |
1 similar comment
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
withoutEnlargement()andmax()methods are the ones that, together, will match ImageMagick's behaviour. I added a mention tomax(), which I would have found helpful.