Pass tile depth parameter down to libvips #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marvellous, thank you very much Alun, this will be included in v0.20.6. |
lovell
added a commit
that referenced
this pull request
Aug 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Lovell,
Stumbled across this issue while using sharp #1281 and thought I'd have a bash at it...
I don't see 'teeth' in the list of branches as a target for this pull request, am I missing something or am I right to use master (it should be non-breaking but it is a change/addition to the api)
Since libvips chooses a default depth based on the layout detected, I thought it best that sharp didn't choose one itself and instead not provide anything unless explicitly set in the javascript.
Alun.