Update output.js #2581
Merged
Update output.js #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is my first request so I'm not quite sure about the conventions. Please let me know if something needs improvement. I added a const formatLowerCase at line 190 that saves the lowerCase version of the format parameter. At 192 and 194 I replaced "format" with "formatLowerCase.
lovell
requested changes
Feb 16, 2021
There was a problem hiding this comment.
Hi, thank you very much for the PR.
Please can you run npm test locally to ensure all the linting rules and unit tests still pass. If you could also add a test to cover this new feature e.g. .toFormat('JPEG') that would be even better.
I've also left one comment inline that will need addressing.
added 2 commits
February 17, 2021 16:00
|
Updated output.js to accept upper case characters. |
lovell
approved these changes
Feb 17, 2021
|
Brilliant, thank you very much. |
|
v0.27.2 now available, thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first pull request (at all!). Please let me know if something needs improvement.
I added a const formatLowerCase at line 190 that saves the lowerCase version of the format parameter.
At 192 and 194 I replaced "format" with "formatLowerCase.