install: fix proxy authentication when password contains special character #2664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When we install
sharp
module on a machine which is behind a proxy, we have an errorERR! sharp tunneling socket could not be established, statusCode=407
if the password contains special characters.This problem is because the
agent()
function returns apassword
where special characters are encoded.To fix this problem, we just need to decode password before to return it.
Open to any suggestions of course.