Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor grammatical error in Installation docs #2668

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Fix minor grammatical error in Installation docs #2668

merged 2 commits into from
Apr 21, 2021

Conversation

rajrajhans
Copy link
Contributor

Changed Alibaba provide a mirror site to Alibaba provides a mirror site.

Changed `Alibaba provide a mirror site` to `Alibaba provides a mirror site`
@coveralls
Copy link

coveralls commented Apr 21, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 17156d5 on rajrajhans:patch-1 into 4237f55 on lovell:master.

@lovell
Copy link
Owner

lovell commented Apr 21, 2021

Hello, thanks for the PR, this is a British vs American English grammatical difference. The current text uses British English; company names are collective nouns and are considered plural.

Perhaps the sentence could be rewritten to avoid ambiguity?

- Alibaba provide a mirror site based in China containing...
+ A mirror site based in China, provided by Alibaba, contains...

@rajrajhans
Copy link
Contributor Author

Sure, thanks for the reply : )

@lovell lovell merged commit f8a7637 into lovell:master Apr 21, 2021
@lovell
Copy link
Owner

lovell commented Apr 21, 2021

Great, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants