Add attention_x and attention_y as output to attention based crop #3470
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The relevant changes will be released in version 8.14 of libvips. |
lovell
requested changes
Dec 1, 2022
|
@lovell - Thank you, feedback adressed. The newest libvips release also includes the attentionX and attentionY fields. Is there an approximate timeline for the next release? |
ejoebstl
changed the title
|
Thanks for the updates, please can you rebase against the |
* Respect scale when computing attentionX/Y
|
Done 🙌 |
|
Thanks for the updates, LGTM. The Windows failures are due to what appears to be a possible bug in that latest |
lovell
approved these changes
Jan 15, 2023
lovell
added a commit
that referenced
this pull request
Jan 16, 2023
|
Danke schön Emanuel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is in response to #3084 and builds upon the following PR in libvips.
The code change exposes the coordinates of the center of attention when using attention based smart cropping.
I'd suggest to merge this PR after my changes are included in libvips.