Add ability to read and write native vips .v files #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please can you add a test case for saving a vips-format file, otherwise (after a rebase) this looks great, thank you very much. |
|
Wow, look at that. Unit tests work! Added the test you asked for and caught a bug with it ;) |
|
Thanks for the updates Matt. Given vips format is filesystem-only, we won't need any of the additions to |
| @@ -139,7 +139,7 @@ NAN_METHOD(format) { | |||
| // Which load/save operations are available for each compressed format? | |||
| Local<Object> format = New<Object>(); | |||
| for (std::string f : { | |||
| "jpeg", "png", "webp", "tiff", "magick", "openslide", "dz", "ppm", "fits", "gif", "svg", "pdf" | |||
| "jpeg", "png", "webp", "tiff", "magick", "openslide", "dz", "ppm", "fits", "gif", "svg", "pdf", "vips" | |||
There was a problem hiding this comment.
For consistency this should probably be "v".
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds the native vips .v file type to the formats that are file read/write-able in sharp. Vips doesn't seem to support reading/writing vips format to/from buffers, so that capability is not included in this pr.