Support toFormat('jpg') #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thanks for this, please can you fix the linting errors. |
|
Please can you add a unit test for this. |
|
It seems there is no independent unit test for |
|
Thanks for the update, please add a test to test/unit/io.js for now (sorry that file is so big, it needs breaking up). |
lovell
reviewed
May 22, 2017
test/unit/io.js
Outdated
| @@ -253,6 +253,21 @@ describe('Input/output', function () { | |||
| }); | |||
| }); | |||
|
|
|||
| it('Support output to jpg format', function (done) { | |||
| sharp(fixtures.inputJpg) | |||
There was a problem hiding this comment.
Is it worth selecting an input image in a format other than JPEG?
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.