Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more benchmarks #3

Closed
wants to merge 62 commits into from
Closed

Add more benchmarks #3

wants to merge 62 commits into from

Conversation

paulhauner
Copy link

Adds two more benchmarks:

  • Verify a signature against 128 pubkeys.
  • Verify a signature against 128 pubkeys where 1/2 signed one message and 1/2 signed another.

Makes no functional changes.

@paulhauner
Refactor heavily
aa99d02 
The functionality in this crate is awesome, but I wanted to bring it
into line with the code quality of other Rust crates. I also implemented
some of my own opinions on naming, I hope this does not offend the
author. I thank the author muchly for what they have built.
@paulhauner
Add comments to aggregates
0536c2d
@paulhauner
Swap .tostring to a direct .affine
fe45a65
@paulhauner
Restructure directories
dec3be9
@paulhauner
Update readmes
892751e
@paulhauner
Tidy cargo.toml
c978f72
@paulhauner
Add comments, tests for keys
63553f7
@paulhauner
Fix all cargo warnings
1b6d0b2
@paulhauner
Move amcl things into amcl_utils, fix lints
2d9c880
@paulhauner
Add aggregates tests, to_bytes -> as_bytes
e507395
@paulhauner
Update README
50b38bb
@paulhauner
Update README
2697bc2
@paulhauner
Switch to blake2b instead of SHA256
b96d21b
@paulhauner
Change cargo package name
3fa4db4
@paulhauner
Expose Signature struct
9da286c
@paulhauner
Impl fmt::Debug for AggregateSignature
125d20a
@paulhauner
Expose DecodeError
b5119a2
@paulhauner
Implement G1Point struct
23b713a
@paulhauner
Implement G2Point
17c6a6a
@paulhauner
Impl Debug for SecretKey and Keypair
5bcdf17
@paulhauner
Add doc comments to Signature
9940f22
@paulhauner
Implement PartialEq for all public types
19fb21c
@paulhauner
Add missed PartialEq
cf665e2
@paulhauner
Add test for superset of keys on aggregate sig
db1d73b
@paulhauner
Add more agg sig tests
1a22645
@paulhauner
Do affine() on verificaton, not each addition
204405b
@paulhauner
Fix aggregate test
6793fdb 
The shuffled test was not actually testing the public key aggregation in
a shuffled manner.
@paulhauner
Remove unnecessary clone() from tests
e6e0324
@paulhauner
Add test for empty agg pub key
9378611
@paulhauner
Add test for signing across distinct msgs
a429b6b
g-r-a-n-t and others added 28 commits January 19, 2019 17:10
@g-r-a-n-t
tests passing with domain parameter
502910b
@g-r-a-n-t
added a failure case for domain
77f8723
@kirk-baird
Reversed signature and publickey curves with domain
2f68f18
@kirk-baird
Modify hash_on_g2 and map_to_g2 function to use both real and imagina…
1862a70 
…ry parts in x
@kirk-baird
Reversed Signature and Publickey curves with domain, add AggregateSig…
ea3741e 
…nature verify_multiple, modify hash_on_g2 function
@kirk-baird
Add checks to ensure PublicKeys and Signatures are valid on verification
722d4ee
@g-r-a-n-t
version updated 0.3.0
ebd1e4a
@g-r-a-n-t
changed version to 0.4.0
23af095
@kirk-baird
Merge branch 'grant' into reverse-pub-sig-domain
41ac21f
@kirk-baird
Increment version
939c83c
@paulhauner
Merge pull request #3 from sigp/reverse-pub-sig-domain
cf12d44 
Reverse PublicKey and Signature, Add verify_multiple
@kirk-baird
WIP Conform BLS to consensus
61bad66
@kirk-baird
Add compress and decompress, improve tests
f31a1e0
@kirk-baird
Add remaining tests from test vectors
ca18dea
@kirk-baird
Clean-up
62c4a1d
@kirk-baird
Benchmarking for compression, decompression, signing, verifying, aggr…
3b2f871 
…egation of publickeys and signatures
@kirk-baird
Modify Version
f8bd59f
@paulhauner
Merge pull request #4 from sigp/bls-tests
21dcf50 
BLS381 Test Vectors & Consensus
@kirk-baird
Modify mutability of as_bytes
99b2dc2
@kirk-baird
Modify mutability of as_bytes
8cbef6f
@kirk-baird
Merge pull request #5 from sigp/mutability
1c73d01 
Modify mutability of as_bytes
@kirk-baird
Allow decoding infinity point for signatures
52eca86
@kirk-baird
Allow decoding infinity point for signatures
0e8188e
@kirk-baird
Update version and format
ecdc0ac
@kirk-baird
Merge pull request #6 from sigp/empty-signatures-decompressing
7eb6f68 
Empty signatures decompressing
@paulhauner
Wrap all benches in black_box
52654e4
@paulhauner
Add bench for agg sig of size 128
e6f6192
@paulhauner
Add bench for verification across 2 msgs
f0c2d64
@paulhauner paulhauner closed this Feb 23, 2019
@paulhauner
Copy link
Author

Sorry, I should have made this on our repo not this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulhauner @kirk-baird @g-r-a-n-t