Fix stale merge commit issue in private CI #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How would you feel about bundling all of this into a GitHub action so it's encapsulated away from the workflow YAML? |
|
Do you mean create another lowRISC repo for this? |
|
If they need another repo then possibly yeah, we can use it for OpenTitan too in that case. Alternatively I think some actions you can put in an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very rare condition where GitHub triggers the workflow a little bit too fast before the asynchronous mergeability check has completed (only an issue for pull_request_target because pull_request would block on mergeability check completion). To address this issue I added a polling loop to do a few retries.
An example run is here: https://github.com/nbdd0121/ibex/actions/runs/7728003457/job/21067811451 (it fails in a later step due to lack of secrets, but that's expected).