Skip to content

Commit

Permalink
[rom_ext/sival] Remove RSA signed sival dependencies.
Browse files Browse the repository at this point in the history
The `mask_rom` no longer supports RSA sigverify. This change removes
pre-signed and other sival targets that where depending on `mask_rom`
RSA keys.

Signed-off-by: Miguel Osorio <miguelosorio@google.com>
  • Loading branch information
moidx committed May 24, 2024
1 parent 4ccb0a3 commit ba76088
Show file tree
Hide file tree
Showing 12 changed files with 9 additions and 14 deletions.
5 changes: 4 additions & 1 deletion hw/top_earlgrey/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -448,9 +448,12 @@ silicon(
"exit_failure": DEFAULT_TEST_FAILURE_MSG,
"assemble": "{rom_ext}@0 {firmware}@0x10000",
},
# The //conditions:default ROM_EXT needs to be updated to use the following
# target once available:
# //sw/device/silicon_creator/rom_ext/sival/binaries:rom_ext_real_prod_signed_slot_a
rom_ext = select({
"//signing:test_keys": "//sw/device/silicon_creator/rom_ext/sival:rom_ext_fake_prod_signed_slot_a",
"//conditions:default": "//sw/device/silicon_creator/rom_ext/sival/binaries:rom_ext_real_prod_signed_slot_a",
"//conditions:default": "//sw/device/silicon_creator/rom_ext/sival:rom_ext_fake_prod_signed_slot_a",
}),
rsa_key = select({
"//signing:test_keys": {"//sw/device/silicon_creator/rom_ext/keys/fake:rom_ext_test_private_key_0": "test_key_0"},
Expand Down
4 changes: 2 additions & 2 deletions sw/device/silicon_creator/rom_ext/sival/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,8 @@ offline_signature_attach(
srcs = [
":presigning",
],
rsa_signatures = [
"//sw/device/silicon_creator/rom_ext/sival/signatures:rsa_signatures",
ecdsa_signatures = [
"//sw/device/silicon_creator/rom_ext/sival/signatures:ecdsa_signatures",
],
tags = ["manual"],
)
10 changes: 1 addition & 9 deletions sw/device/silicon_creator/rom_ext/sival/binaries/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,4 @@

package(default_visibility = ["//visibility:public"])

filegroup(
name = "rom_ext_real_prod_signed_slot_a",
srcs = ["rom_ext_real_prod_signed_slot_a_silicon_creator.signed.bin"],
)

filegroup(
name = "rom_ext_real_prod_signed_slot_b",
srcs = ["rom_ext_real_prod_signed_slot_b_silicon_creator.signed.bin"],
)
# Add silicon binary targets once available.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
4 changes: 2 additions & 2 deletions sw/device/silicon_creator/rom_ext/sival/signatures/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
package(default_visibility = ["//visibility:public"])

filegroup(
name = "rsa_signatures",
srcs = glob(["*.rsa_sig"]),
name = "ecdsa_signatures",
srcs = glob(["*.ecdsa_sig"]),
)

filegroup(
Expand Down
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

0 comments on commit ba76088

Please sign in to comment.