Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

//sw/device/tests/crypto:rsa_3072_verify_functest_wycheproof tests hang #16805

Closed
drewmacrae opened this issue Dec 13, 2022 · 5 comments · Fixed by #19397
Closed

//sw/device/tests/crypto:rsa_3072_verify_functest_wycheproof tests hang #16805

drewmacrae opened this issue Dec 13, 2022 · 5 comments · Fixed by #19397
Assignees
Milestone

Comments

@drewmacrae
Copy link
Contributor

    Looking into the wycheproof timeouts:
//sw/device/tests/crypto:rsa_3072_verify_functest_wycheproof_fpga_cw310_test_rom TIMEOUT in 900.0s
//sw/device/tests/crypto:rsa_3072_verify_functest_wycheproof_sim_verilator TIMEOUT in 900.0s

Investigating for known good commit.
It's hanging on vector 170 on cw310 (165 for verilator) (seemingly waiting for OTBN to complete) Instrumenting with logging info, has an effect on where it stalls so I should figure out halting and getting IP over GDB to see where it hangs when uninstrumented.

Originally posted by @drewmacrae in #15877 (comment)

@moidx
Copy link
Contributor

moidx commented Jan 27, 2023

CC: @jadephilipoom

@moidx moidx added this to the Project: M3 milestone Jan 27, 2023
@jadephilipoom
Copy link
Contributor

These are some of the longest tests we have -- I think it's possible they are genuinely timing out, not hanging. The Verilator one definitely will not finish in 900s, I think it takes about 7h. I'll look into the FPGA tests and see whether this is hanging or if we just need to split the tests into two Bazel targets/increase the timeout.

@jadephilipoom jadephilipoom self-assigned this Jan 30, 2023
@a-will
Copy link
Contributor

a-will commented Aug 9, 2023

Are we putting the entropy source into auto mode for those tests? And if not, are the tests possibly exhausting the boot-time entropy?

That happened to me when I raised the FPGA frequency in #19368 and found keymgr_sideload_otbn_test started failing. OTBN would get stuck waiting for entropy to complete a secure wipe.

@a-will
Copy link
Contributor

a-will commented Aug 9, 2023

Yup, that was the problem. Threw in an entropy_complex_init() and no more freezing.

@jadephilipoom
Copy link
Contributor

Awesome, thanks @a-will !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants